Reset CONTENT_LENGTH between test requests #32773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a POST request is followed by a GET request in a controller test, the `rack.input` and `RAW_POST_DATA` headers from the first request will be reset but the `CONTENT_LENGTH` header will leak, leading the request object in the second request to incorrectly believe it has a body.
|
I can confirm this indeed fixes GH-32767 🎉 |
georgeclaghorn
added a commit
that referenced
this pull request
May 1, 2018
…ests Reset CONTENT_LENGTH between test requests
|
Backported in 5699abf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #32673.
Fixes #32767.
rails/actionpack/lib/action_controller/test_case.rb
Lines 120 to 121 in ee6a431
If a POST request is followed by a GET request in a controller test, the
rack.inputandRAW_POST_DATAheaders from the first request will be reset but theCONTENT_LENGTHheader will leak, leading the request object in the second request to incorrectly believe it has a body.r? @georgeclaghorn